drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Autoselect first year match #188

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What area does your enhancement or feature relate to? (i.e. Config/Setup,
GUI, options, Skin, AMC Updater, Grabber Interface, etc.)
AMCu

What is the purpose or benefit of the new feature or enhancement?
Automatization, less user intervention required

How would you expect it to work? Can you illustrate it with examples such
as images (screenshots), scenarios or examples from other Plugins?
In most cases, with the year correctly wrote in the file name, the first year 
match is the correct film. So, auto-select it. 
A checkable option in the "import movies" tab - "importer options" area would 
do the trick

If this issue has been discussed in the MyFilms forum, add a link to the
related thread or post.

Please sign with your MP forum username as often google accounts are quite
different.

z3us

NOTE: feature requests will be evaluated based on the number of
users who 'star' the issue as well as the details provided.

Original issue reported on code.google.com by vivamiloro on 7 Sep 2012 at 2:49

Attachments:

GoogleCodeExporter commented 8 years ago
That is already done - choose "select best match".
However, in this special case, the name was too different from the one you 
searched, that the automatcher did not approve it (see "distance" column).

Original comment by Guzz...@googlemail.com on 8 Sep 2012 at 4:37

GoogleCodeExporter commented 8 years ago
Any feedback? We either need an improvement description over what we already 
have - or close this issue...

Original comment by Guzz...@googlemail.com on 15 Sep 2012 at 7:20

GoogleCodeExporter commented 8 years ago
What´s the distance default value? Maybe it could be modified or directly an 
option to autoselect first year match. As I said, the window prompts a lot of 
times (looks for translated title), and the first year match is always the good 
one

Original comment by vivamiloro on 15 Sep 2012 at 9:10

GoogleCodeExporter commented 8 years ago
Here's another good case ;) Men in Black 3 - screenshot shows match results 
sorted by 'distance' - Although there is more than one match based on 
'distance' there is ONLY one match with distance AND year. So I agree with 
z3us, I think even if name is not unique and there is more than one match using 
'distance' AMCU should match if there is only one match by year.

Original comment by Dade...@gmail.com on 16 Sep 2012 at 4:12

Attachments:

GoogleCodeExporter commented 8 years ago
Yes, i see this a lot with movie remakes. I have the original movie with the 
year attached and still it pops up because there has been a remake, this can be 
very annoying.

Original comment by Ted98...@gmail.com on 17 Sep 2012 at 4:57

GoogleCodeExporter commented 8 years ago
Matchingdistance must be <3, if year hint is given and <2, if no year hint is 
there.
Re Dadeos example: That one does autoimport here, as expected - did you maybe 
select "always ask" in AMCU imoprter settings?
Re changing behaviour: Sure, we can do that. We also could make it configurable 
(e.g. matchingdistance).
But best is for sure to look at examples and discover, WHY it did not 
automatch. Then it is finding the best relation bew´tween wrong automatches 
and arong askings ;-)

Original comment by Guzz...@googlemail.com on 24 Sep 2012 at 10:45

GoogleCodeExporter commented 8 years ago
No I did not have 'always ask' set (I never do!) 

Did you use IMDB-Full grabber when it auto matched? Because according to the 
rules you state above, both MIB 3 and MIB 4 meet the distance criteria (<2 for 
MIB 4 with no year hint as it had no year) so AMCU functioned correctly in 
asking me to manually match (based on current rules) 

Please test with 'always ask' enabled to see what distance you get for those! 
[I enjoyed saying that ;)]

Original comment by Dade...@gmail.com on 25 Sep 2012 at 5:08

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 27 Oct 2012 at 9:52

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 30 Oct 2012 at 3:32

GoogleCodeExporter commented 8 years ago
Ok guys - what should we do with this one?
I think the only way is to introduce a setting to let the user set the auto 
matching distance - so those who prefer to get more automated import at risk of 
wring matches can rise it.
Any better suggestions?

Original comment by Guzz...@googlemail.com on 21 Nov 2012 at 2:41

GoogleCodeExporter commented 8 years ago
I do not think we need to change distance matching. 

Imo IF there is more than one match that meets distance criteria, but ONLY one 
matches year hint then it should auto match that movie. This would auto match 
considerably more movies because AMCU and distance matching is very good - the 
problem is that it seems to use only distance matching not distance + Year.

In all cases presented in this issue, year Search hint exists, and there is 
only ONE movie that matches the title and year hint - so  why is it not 
auto-matched? The reason given is that there are other movies that match 
distance criteria - which implies year criteria is overridden by distance 
criteria.

Original comment by Dade...@gmail.com on 21 Nov 2012 at 7:34

GoogleCodeExporter commented 8 years ago
Dadeo is right it seems like the year criteria is overridden by distance 
criteria.

Original comment by Ted98...@gmail.com on 21 Nov 2012 at 9:19

GoogleCodeExporter commented 8 years ago
Actually, in AMCU GUI mode, the matching criteria are very "narrow".
They are less narrow on background import - so possibly the same movie might 
"slip through" there.
Matching rule does NOT match when year is there, if distance is too high - yes, 
too high distance does NOT allow the engine to match the movie.
That makes sense, as we had in our many tests cases, where otherwise you'd get 
wrong matches, just based on a matching year.
Yes, it would always "work good" with poopular titles - but as soon as you have 
less popular titles, it will giove you a lot false positives.
As I said, I am happy to add an option for you guys, so you can use taht, if 
you prefer, I prefer to have less or no mismatched movies for the price the 
price of a missing match.
(Actually, you have to make many many many tests with many different movies to 
get a "good tweaked" matching engine)

Original comment by Guzz...@googlemail.com on 23 Nov 2012 at 9:06

GoogleCodeExporter commented 8 years ago
Ok, to get this to a decision, we need feedback from z3us, if that option does 
meet his feature request/requirements.
If not and there is no better  suggestions, I would reject/close this issue.

Original comment by Guzz...@googlemail.com on 1 Dec 2012 at 11:07

GoogleCodeExporter commented 8 years ago
It may be worth retesting with the changes in search results on IMDb
Most of the test cases I reported or used for testing manual matches 
previously, now auto match in 'Background mode' i.e. when importing via MF GUI 
Import.

Original comment by Dade...@gmail.com on 1 Dec 2012 at 11:24

GoogleCodeExporter commented 8 years ago
That option is ok for me

Original comment by vivamiloro on 24 Dec 2012 at 2:53

GoogleCodeExporter commented 8 years ago

Original comment by Guzz...@googlemail.com on 29 Jun 2013 at 5:13