drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Auto update Subtitles field when Subtitles are available #192

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What area does your enhancement or feature relate to? (i.e. Config/Setup,
GUI, options, Skin, AMC Updater, Grabber Interface, etc.)
GUI, AMC Updater
What is the purpose or benefit of the new feature or enhancement?
To enable DB to display data in Subtitles field (and thus a subtitle logo in 
GUI) whenever you add a Subtitle - either via SubCentral (from My Films Details 
context menu) or externally
How would you expect it to work? Can you illustrate it with examples such
as images (screenshots), scenarios or examples from other Plugins?
MF checks movie folder - at least for .sub or .srt files (similar to the way it 
registers Trailers):
1. When downloading via MF/SubCentral integration it automatically adds the 
LANGUAGE in the Subtitles field (SubCentral uses MP file name convention - i.e. 
%moviename%.%language%.@ext@) - one language per subtitle file?
2. If subtitles are added externally, user has an option to search/add them in 
Details context menu (or Global updates)
3. When Importing new movies, or Updating movies via AMCU IF .sub/.srt file 
exists in movie folder or with same name as movie, then Subtitles field is 
updated with the language in the subtitle file name. If no language exists in 
the filename AMCU could default to current OS language.
4. When Updating data in GUI (Get Internet Info) - MF checks for subtitles file 
and displays Subtitles language Multi-Select dialog of fields to update.

I am not sure how DVDs, BRDs, container files like .mkv that include subtitles 
report them, but that probably also needs to be considered for auto updates.

Original issue reported on code.google.com by Dade...@gmail.com on 9 Sep 2012 at 4:27

GoogleCodeExporter commented 9 years ago
First of all: There IS already Subtitle support at least in AMCupdater:
Subtitles are retrieved from mediainfo (text stream list) and loaded into 
subtitle field. So what is missing is parsing external subtitles.
Can you provide something like a full spec - or can we rely on the 
specification above, only checking for .sub and .srt files?
Do we need an additional folder to be checked - or only in the movie folder?

Original comment by Guzz...@googlemail.com on 15 Sep 2012 at 11:40

GoogleCodeExporter commented 9 years ago
"If no language exists in the filename AMCU could default to current OS 
language." I wouldn´t like this to happen. Better fill subtitles field with 
"true" or "yes"

"So what is missing is parsing external subtitles."  OrionHall added this 
feature in the past, has it been lost?. I requested Orionhall to add it, and 
now I ask you for it again ;)

"Do we need an additional folder to be checked - or only in the movie folder?" 
The subtitle paths are set in the MP config, see attached pic

Original comment by vivamiloro on 19 Oct 2012 at 4:59

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 27 Oct 2012 at 9:54

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 30 Oct 2012 at 3:31

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 24 Nov 2012 at 11:43

GoogleCodeExporter commented 9 years ago
Can you please provide some examples as ZIP for coding and testing.
One sample should also be added to sample movies folder imho.

Original comment by Guzz...@googlemail.com on 25 Nov 2012 at 2:02

GoogleCodeExporter commented 9 years ago
Issue 423 has been merged into this issue.

Original comment by Dade...@gmail.com on 25 Mar 2015 at 7:11