search

drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Trakt rating pop-up does not work correctly when playing film from Main Screen #193

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Case 1:
1. Open My Films
2. Play a movie from My Films Main Screen using play button

What is the expected output? What do you see instead?
No Trakt rating popup displays

Case 2:
1. Go to Details Screen first
2. Go back to Main Screen
3. Play a Movie

What is the expected output? What do you see instead?
Trakt rating pop-up displays BUT for the first movie in the facade/list (no 
matter how it is sorted)

Please use labels and text to provide additional information.
Note:  Trakt rating pop-up displays correctly for the same film when played 
from Details Screen.

Original issue reported on code.google.com by Dade...@gmail.com on 10 Sep 2012 at 4:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixing this issue will require to move all the message communication from 
details to main window.
This will break the interfaces for plugin integration e.g. with trakt and thus 
will require changes in trakt plugin to match those changes.
So question is: Do we want to do this before v6 goes public?
Advantage is, we got those issues solved before new public version and don't 
need to breal compatibility after that. Disadvantage is, that we will need 
upates for other plugins (at least trakt, would have to check, if others are 
affected too) for V6 right away.
So do you want this for now?

Original comment by Guzz...@googlemail.com on 14 Sep 2012 at 7:31

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2518.

Original comment by Mikeplan...@web.de on 14 Sep 2012 at 8:22

GoogleCodeExporter commented 9 years ago 
In build 2532:
Trakt rating popup does not display when playing a film from Main screen.
If you go to Details screen first, then back to main and play a film, it 
displays for the correct film.

Imo this is acceptable for 6.0, given the complexity of changing message 
communication.  Let's see how many users even have Trakt enabled and try to 
play a film from Main view!

For now I added a note to Trakt Wiki page that rating popup displays when you 
fully play a film from Details screen.

Original comment by Dade...@gmail.com on 16 Sep 2012 at 6:21