Playing a video adds an entry and data to MyVideos DB

drtak34 / my-films

Automatically exported from code.google.com/p/my-films

0 stars 0 forks source link

Playing a video adds an entry and data to MyVideos DB #222

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Play a video/movie from My Films
2. Go to Videos plugin in MP
3. The movie is added to the Video DB, but with minimal data

What is the expected output? What do you see instead?
I don't expect a movie to be added to Video DB unles I request it. Also, it 
seems only data populated in OSD is added (play.current properties).

Please use labels and text to provide additional information.
To be fair, this behaviour has existed in MyFilms for some time and perhaps was 
originally intended. However it is not consistent with the behaviour of any 
other MP extension AFAIK. With the expansion of the video DB in MP 1.3.0 it 
become more of an issue because more users are likely to use Videos DB in MP 
and because there are many more properties/fields now that are not 'populated' 
for the entries My Films adds.

Original issue reported on code.google.com by Dade...@gmail.com on 11 Oct 2012 at 1:11

GoogleCodeExporter commented 9 years ago

Actually, MF films were not added with minimal data, but with full data - as 
far as MyVideo MF film properties could be matched to MyVideo properties.
Checking the code, there is quite some synchronisation implemented - Films used 
in MF are added to VDB, even Films deleted from MyFilms are deleted from VDB DB.
So I am quite sure, this was intended behaviour, as there is quite some code 
making sure all this happens.

Original comment by Guzz...@googlemail.com on 11 Oct 2012 at 11:41

GoogleCodeExporter commented 9 years ago

As I said, MF 6 adds support for many extended fields, and Videos 1.3.0 also 
adds support for additional fields (even a few not supported in MF like votes).

If you prefer I can change the issue to 'does not add all data correctly' ;). 
However, IF the feature remains I think there should be a setting to 
enable/disable it. MF should not alter a user's Video DB without their consent.

Original comment by Dade...@gmail.com on 12 Oct 2012 at 1:18

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r2605.

Original comment by Mikeplan...@web.de on 13 Oct 2012 at 12:45

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

in build 260 I can verify that playing a video no longer adds it to Videos DB 
in MP 1.3.0. Resume playback still works correctly. Watched date/count are 
updated correctly. OSD properties all look good - covers and all play current 
tags display. MUS data all seems good.

Tested playback both from Main and Details Screen.

The only issue I have found so far is that Trakt rating popup no longer 
displays. However I am not sure if this is related to this issue or not. 
Attached Log files and reopened this issue for now.

I am not sure what else to test as I don't know what other 'features' may be 
affected by this change.

Original comment by Dade...@gmail.com on 13 Oct 2012 at 8:46

Changed state: ReOpened

Attachments:

MyFilms_Traktlog.rar

GoogleCodeExporter commented 9 years ago

Scratch the Trakt Issue - unticking Add-ons in installer reverted Trakt to 2.0.0

All looks good so far!

Original comment by Dade...@gmail.com on 15 Oct 2012 at 3:15

Changed state: Verified