search

drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Allow local caching for trailers of online content #261

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This issue relates to issue#230 - online content
When internet line or webservers lack bandwith, online trailers can't be played 
without playback issues - thus trailers should be cached to the extended 
trailer directory for local playback.
Trailer Download Queue is used for that purpose - when browsing online content, 
the respective online traielrs are added to download queue and loaded in the 
background.
When selecting an item in online content lists, the additional option for local 
cached content is added (to local movies, if present and online trailers)

Original issue reported on code.google.com by Guzz...@googlemail.com on 9 Nov 2012 at 8:29

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2686.

Original comment by Mikeplan...@web.de on 9 Nov 2012 at 8:30

GoogleCodeExporter commented 9 years ago 
Added option to enable/disable - default disabled. (testmode)

Original comment by Guzz...@googlemail.com on 9 Nov 2012 at 9:06

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2688.

Original comment by Mikeplan...@web.de on 9 Nov 2012 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 13 Nov 2012 at 4:35

GoogleCodeExporter commented 9 years ago

Original comment by Dade...@gmail.com on 14 Nov 2012 at 5:24

GoogleCodeExporter commented 9 years ago 
Works well BUT there seems to be an issue with stopping the cache:
To reproduce:
1. Go to Online Info view > Now Playing
2. Enable Trailer Caching via Global Settings in GUI
3. Trailers are correctly cached to <extended trailer search 
path>\OnlineTrailerCache
4. Disable Trailer caching via Global Settings in GUI
Caching does not stop! And when I quit MP it was still loaded (waiting for 
trailer to finish caching?)

Updated Docs 
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/3_Using_My_Films/Trailers#section_9

Original comment by Dade...@gmail.com on 21 Jun 2014 at 5:17

GoogleCodeExporter commented 9 years ago 
That behaviour is intended:
- When you shut down, the trailers currently loaded will try to end - there is 
a timeout of 120 seconds, that will kill those processes - otherwise MP would 
never shut down completely.
- Reason is: Whenever a trailer starts loading, it is taken out of the wait 
queue - so if we'd kill download immideately, we wouldn't get those after 
restart - as only trailers in the queue are saved to disk and restarted on next 
MP/MF startup.
To change that, we'd have to change the qeue implementation, which is a bigger 
task. I noticed that behaviour before, but didn't want to spend so much time, 
as I could live with it.
The second issue about global setting:
True, currently, this only decides, IF trailers should be added to the DL 
queue. I will change it to stop loading trailers in the queue - however, again, 
this will stop after the threads have finished their current download.

Original comment by Guzz...@googlemail.com on 21 Jun 2014 at 2:49

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r3034.

Original comment by Guzz...@googlemail.com on 21 Jun 2014 at 5:16

GoogleCodeExporter commented 9 years ago 
Verified disabling setting in GUI now stops caching (after current dodwnload is 
done).
Removed TestMode label as it is already moved to normal mode.
Added note/warning about this option to Docs.

Original comment by Dade...@gmail.com on 22 Jun 2014 at 4:48