search

drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Use Localized Plugin Name in CurrentModule #326

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What area does your enhancement or feature relate to? (i.e. Config/Setup,
GUI, options, Skin, AMC Updater, Grabber Interface, etc.)
Skin Properties
What is the purpose or benefit of the new feature or enhancement?
Currently the plugin name set in #currentmodule seems to be hardcoded (Films). 
Since Default (and many skins) use #currentmodule it would be better to use 
#myfilms.config.pluginname (which already exists) to display the name the user 
chooses in Setup (e.g. 'Mes Films' for the original users ;))
How would you expect it to work? (Accessed via, new settings required, Skin
changes/new properties)
Just like now but instead of hardcoding the plugin name.

Can you illustrate it with examples such
as images (screenshots), scenarios or examples from other Plugins?

Display would be 'Mes Films\Films\All'

Original issue reported on code.google.com by Dade...@gmail.com on 2 Mar 2013 at 11:02

GoogleCodeExporter commented 9 years ago 
I checked code - the "currentmodule" used the localized strong from strings 
file with ID 7986 - hoewever, will change it to use plugin name configured in 
setup

Original comment by Guzz...@googlemail.com on 3 Mar 2013 at 9:58

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2848.

Original comment by Mikeplan...@web.de on 3 Mar 2013 at 9:59

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2850.

Original comment by Mikeplan...@web.de on 3 Mar 2013 at 10:36

GoogleCodeExporter commented 9 years ago 
In build 2853 visibility condition plugin.isenabled(MyFilms) is no longer 
working. I assume this is related to this change, because if I change it to 
plugin.isenabled(Films) it works. 

The feature request was only to change the display name in #currentmodule (like 
other plugins do) NOT to change the actual pluginname ;)

Original comment by Dade...@gmail.com on 23 Mar 2013 at 2:47

GoogleCodeExporter commented 9 years ago 
Steps to reproduce:
1. Change Plugin Name in Setup to e.g. 'Films'
2. Open MyFilms Menu (where Recently added media from Latest Media Handler 
displays)

No data displays because the skin properties are depending on 
plugin.isenabled(MyFilms)

Original comment by Dade...@gmail.com on 28 Jun 2013 at 3:52

GoogleCodeExporter commented 9 years ago 
Set prio high, as skins depend on it, so it affects usability

Original comment by Guzz...@googlemail.com on 29 Jun 2013 at 2:38

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2874.

Original comment by Mikeplan...@web.de on 29 Jun 2013 at 3:13

GoogleCodeExporter commented 9 years ago

Original comment by Dade...@gmail.com on 1 Jul 2013 at 4:58