Closed GoogleCodeExporter closed 9 years ago
Original comment by Dade...@gmail.com
on 27 Nov 2013 at 3:31
Original comment by Guzz...@googlemail.com
on 18 Jun 2014 at 10:17
This issue was closed by revision r3003.
Original comment by Guzz...@googlemail.com
on 18 Jun 2014 at 10:18
OK I added some sample logos in country subfolders for testing.
1. In Logos Setup select MyFilms logos
2. Enter a country code (au, de, uk, us)
3. You must have valid data in Certification field for the logo rules to work
You probably won't see much difference for DE or US since we already had those
logos, but if you have movies with cert '18' and switch between DE and UK you
should get a diff logo.
For US Certifications the best one to test is 'R' and switch between au and us
country codes. PG will also work with au, uk, us but I only had PG-13 movies. ;)
The only issue I have seen is in the Logos Editor/Setup
1. As always you must save, exit, reload before you will see the different
logos in the 'click to select logo' preview when you select a rule.
2. The image paths in editor do not update to show the correct sub folder. They
seem to default to the first case found. So if you select 18 rule the image
path displays C:\ProgramData\Team
MediaPortal\MediaPortal\thumbs\MyFilms\DefaultLogos NOT C:\ProgramData\Team
MediaPortal\MediaPortal\thumbs\MyFilms\DefaultLogos\uk (if you have selected UK
as country.
However the biggest issue is that we need to add logo rules for the
certification values for each country supported!
Original comment by Dade...@gmail.com
on 24 Jun 2014 at 11:20
This issue was closed by revision r3054.
Original comment by Guzz...@googlemail.com
on 24 Jun 2014 at 11:51
This issue was closed by revision r3055.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 12:31
Have added both #myfilms.config.country and "value2 as comparator in logo
manager - so rules to setup should be easy - maybe just one to use DB field
value.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 12:37
First the good news ;)
1. Backwards compatibility seems fine - if skin has no country subfolders then
logos display as before.
2. #myfilms.config.country works
I don't know what to do with 'value2' comparator, but since it is so easy,
maybe you can commit a sample MyFilmsLogos.xml ? ;)
The bad news is
#myfilms.config.country always displays 'en-US' for me no matter what I enter
in Logos Setup
Log shows:
2014-06-25 13:42:05,817 Debug [ 1 | Logos ]: Logo Country: 'DE', MP language
= 'en-US'
So it looks like the property is ONLY getting MP language, not Logo country (I
tried DE, us, au, uk....)
Also, the Logo Country only searches one folder level below a 'logos' subfolder
(is a \logos folder required?)
I suspect many skins (like aMPed) will prefer to use logos\ratings(or
certification)\<country code>
It took me ages to figure out why it wasn't working! LOL
Original comment by Dade...@gmail.com
on 25 Jun 2014 at 8:45
Sample is written in tooltip of the comparator:
"Certification", "value", "", "", "", "", "", ""
Re issue: I fixed one problem in latest build, if you test build 3043, it
should use logo manager country setting.
Re directory structure: yes, it is always one sub below 'logos'. But you could
theoretically define COuntry = 'ratings\de' - but with such a structure, the MP
,anguage autodetection woudln't work anymore - this would require code changes.
What to do?
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 9:06
This issue was closed by revision r3060.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 9:22
This issue was closed by revision r3062.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 6:24
This issue was closed by revision r3063.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 6:48
This issue was closed by revision r3064.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 8:10
This issue was closed by revision r3065.
Original comment by Guzz...@googlemail.com
on 25 Jun 2014 at 8:17
This issue was closed by revision r3071.
Original comment by Guzz...@googlemail.com
on 26 Jun 2014 at 10:13
This issue was closed by revision r3074.
Original comment by Dade...@gmail.com
on 27 Jun 2014 at 1:55
This issue was closed by revision r3076.
Original comment by Guzz...@googlemail.com
on 27 Jun 2014 at 2:10
This issue was closed by revision r3077.
Original comment by Guzz...@googlemail.com
on 27 Jun 2014 at 2:19
This issue was closed by revision r3079.
Original comment by Dade...@gmail.com
on 27 Jun 2014 at 3:16
[deleted comment]
OK I updated MyFilmsLogos.xml with new value rule. Please check it also works
for you in the following use cases:
1. No country selected in Logos Setup
2. Country selected in logos setup
3. Using MP Logos pack
4. Using skin logos with no country folders for cert logos
5. Copy MF logos country folders to skin of choice and test
a) with country selected
b) with no country selected
I have not verified issue yet because I think we need to test on more than one
system/user settings.
I am still hesitant about asking skinners to create media\logos\<country>
folders, as I don't know if they will! But let's ignore my negativity and try
it. Users' can always do it if skins don't!
Also please check Docs Updated:
http://wiki.team-mediaportal.com/index.php?title=1_MEDIAPORTAL_1/17_Extensions/3
_Plugins/My_Films/00_What%27s_New/Version_6.1#Certification_logos_by_country
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/Skinning_My_Films/Skinning_Logos#Certification_logos_by_country
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/20_Setup_Guides/Custom_Artwork#Certification_logos_by_country
Original comment by Dade...@gmail.com
on 27 Jun 2014 at 3:28
This issue was closed by revision r3081.
Original comment by Guzz...@googlemail.com
on 27 Jun 2014 at 7:07
This issue was closed by revision r3082.
Original comment by Guzz...@googlemail.com
on 27 Jun 2014 at 11:25
This issue was closed by revision r3084.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 11:25
This issue was closed by revision r3085.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 11:28
This issue was closed by revision r3086.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 11:55
This issue was closed by revision r3087.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 12:12
This issue was closed by revision r3088.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 12:33
This issue was closed by revision r3089.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 1:25
This issue was closed by revision r3090.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 4:05
This issue was closed by revision r3091.
Original comment by Guzz...@googlemail.com
on 28 Jun 2014 at 8:51
This issue was closed by revision r3094.
Original comment by Dade...@gmail.com
on 29 Jun 2014 at 4:23
This issue was closed by revision r3095.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 9:30
This issue was closed by revision r3096.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 9:32
This issue was closed by revision r3097.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 9:47
This issue was closed by revision r3098.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 9:56
This issue was closed by revision r3100.
Original comment by Dade...@gmail.com
on 29 Jun 2014 at 12:13
This issue was closed by revision r3101.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 2:21
This issue was closed by revision r3102.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 2:28
This issue was closed by revision r3103.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 2:35
Original comment by Dade...@gmail.com
on 29 Jun 2014 at 4:50
This issue was closed by revision r3104.
Original comment by Guzz...@googlemail.com
on 29 Jun 2014 at 10:49
Verified again - MP Language fallback now works much better (getting last 2
digits of language code) though it will never be 100% since language codes and
country codes don't always match!
I updated all docs with latest (better) implementation, and added a FAQ entry:
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/17_Extensions/3_Plugins/My_Film
s/0_My_Films_FAQ/Certification_logos_don't_display
Original comment by Dade...@gmail.com
on 30 Jun 2014 at 4:40
This issue was closed by revision r3105.
Original comment by Dade...@gmail.com
on 30 Jun 2014 at 8:45
Verified change to DefaultLogos\uk to DefaultLogos\gb although installer does
not remove \uk
Original comment by Dade...@gmail.com
on 1 Jul 2014 at 6:28
Original issue reported on code.google.com by
Dade...@gmail.com
on 27 Nov 2013 at 3:31