drtak34 / my-films

Automatically exported from code.google.com/p/my-films
0 stars 0 forks source link

Collection covers grabbed via TMDB grabbers don't display #380

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Select TMDB-DE grabber (the only one that previously supported collection 
covers)
2. Select a move that belongs to a collection on TMDB
3. Import or update the movie via AMCU

What is the expected output? What do you see instead?
Expect the collection cover to display in GUI, but it doesn't because grabber 
engine is hard-coded to save it as "Collection_<movie>.jpg" whereas GUI looks 
for a match to the Collection name.

Please use labels and text to provide additional information.
Example:  If you grab Collection cover via GUI (using TMDB API v3) for Step Up 
Collection it is saved as Step Up Collection.jpg in covers folder and displays 
correctly.  But if you import using TMDB grabber it is saved as Collection_Step 
Up 3D.jpg (where movie name is Step Up 3D)

Original issue reported on code.google.com by Dade...@gmail.com on 10 Feb 2014 at 8:32

GoogleCodeExporter commented 9 years ago

Original comment by Guzz...@googlemail.com on 6 Apr 2014 at 12:47

GoogleCodeExporter commented 9 years ago
This also depends in issue#379 (rework of grabber core)
Problem is, that the movie grabber does not know about an intended "collection 
name" in GUI - the user might use any name, that he/she prefers, which might be 
the root directory name, the TMDB collection name or anything given by the user.
So matching at this point is somehow difficult.
The grabber can grab the collection cover and we can choose how to save it to 
disk.
So which name should we use?
Currently, the grabber uses the movie title to build the name - I will change 
it to use the collection name (as internal TMDB grabber does)!?
However, that might need further details, once the grabber core is reworked.

Original comment by Guzz...@googlemail.com on 6 Apr 2014 at 3:26

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2976.

Original comment by Guzz...@googlemail.com on 6 Apr 2014 at 3:41

GoogleCodeExporter commented 9 years ago
Reopened
Collection cover is now saved as:
Collection_Step Up 3D.jpg
Collection_Step Up Revolution.jpg

Should be saved as what TMDB script grabs for Collection (e.g. Step Up 
Collection) +.jpg

Original comment by Dade...@gmail.com on 21 Jun 2014 at 1:26

GoogleCodeExporter commented 9 years ago
I do know what you mean about how the collection has been 'grouped' (which 
results in the Collection name).  It is not only an issue with how you name 
your group (based on group folder), but movies may not even use the same name 
in other languages (e.g. Step up is called 'Let's Dance' in some countries.) :(

So I am not sure what the solution is! AMCU knows the 'Group' name (which is 
added to the Title field) but grabber doesn't! So unless AMCU can rename the 
collection image to: '<user's group name> Collection.jpg" , it seems to me that 
AMCU/Grabber should at least be consistent with GUI download collection cover?

Original comment by Dade...@gmail.com on 21 Jun 2014 at 1:45

GoogleCodeExporter commented 9 years ago
TMDB Collection grabber can never know about your file system organization, 
which is used by AMCU to create group names.
So I think what we currently have is the best we can do.
When we add Collections as DB field, those TMDB collection images can be used 
for those collection group views.
I'll close this one again, as I think that the original issue was solved.

Original comment by Guzz...@googlemail.com on 21 Jun 2014 at 2:35

GoogleCodeExporter commented 9 years ago
Currently only TMDB-DE grabs collection/covers in any case.
If you don't have a ton of groups, and that is just for testing.
This issue is actually invalid because grabbing collection covers via AMCU 
import is not a supported (or documented) feature yet ;)!

Original comment by Dade...@gmail.com on 21 Jun 2014 at 6:06