search

drtimcooper / LatLongToTimezone

Lat/long to timezone mapper in Java. Does not require web services or data files - just pure Java or Swift.
MIT License
168 stars 33 forks source link

Compile warnings for Xcode 10/Swift 4.2 #21

Closed SjaakSchilperoort closed 6 years ago

SjaakSchilperoort commented 6 years ago

After updating to the latest version of Xcode, I get two compile warnings in the swift source file TimezoneMapper.swift. "open static" should now be "public static". I've created a fix, but encountered an unexpected project setup. The podspec on cocaopods is apparently based on an unmerged commit which is tagged "1.1.2". Shouldn't this have been merged to master? I wanted to create a pull request, but with master being out-of-date I'm not sure how to proceed. Could you please look into this? Thanks!

akirmse commented 6 years ago

I'm working on a new version (the code for which is actually already checked in), but unfortunately I'm running into this Cocoapods bug when trying to update the podspec: https://github.com/CocoaPods/CocoaPods/issues/7708

Ariandr commented 6 years ago

Hello @akirmse It seems they fixed the bug. So, could you please try to update the pod again?

akirmse commented 6 years ago

I was able to update using the beta version of cocoapods.

The new version of this pod is 1.1.5.

Ariandr commented 6 years ago

Great, thank you!