search

drtimcooper / LatLongToTimezone

Lat/long to timezone mapper in Java. Does not require web services or data files - just pure Java or Swift.
MIT License
167 stars 33 forks source link

Change SWIFT_VERSION #25

Closed Tapestes closed 5 years ago

Tapestes commented 5 years ago

Looks like as of xcode 10.2, we can no longer compile Swift 3.0 if we have an app targeting 4.0 or later. Could you change the target to 4.0 or 4.2?

akirmse commented 5 years ago

I'm using this with a Swift 5 project successfully, and in the podspec I see that it declares swift_version of 4.2. Can you tell me where the target needs to be changed?

On Fri, Mar 29, 2019 at 1:09 PM Steven Estes notifications@github.com wrote:

Looks like as of xcode 10.2, we can no longer compile Swift 3.0 if we have an app targeting 4.0 or later. Could you change the target to 4.0 or 4.2?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKU8vkqb-kgSYet06hqZSnis3a3vqZrks5vbnMFgaJpZM4cTKMX .

Tapestes commented 5 years ago

Sure. Open up the xcode project in the carthage folder, select the target in xcode in the left side navigation panel, and select the build settings tab. Then look through the build settings for Swift Compiler Language. You should see it’s set to Swift 3.0. If you change it to 4.2, that should allow carthage to compile with the latest xcode command line tools. I did this on a fork I created yesterday and verified it fixes the carthage issue. If you’d prefer, I can create a pull request.

Gracias

On Sat, Mar 30, 2019 at 12:59 AM Andrew Kirmse notifications@github.com wrote:

I'm using this with a Swift 5 project successfully, and in the podspec I see that it declares swift_version of 4.2. Can you tell me where the target needs to be changed?

On Fri, Mar 29, 2019 at 1:09 PM Steven Estes notifications@github.com wrote:

Looks like as of xcode 10.2, we can no longer compile Swift 3.0 if we have an app targeting 4.0 or later. Could you change the target to 4.0 or 4.2?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/issues/25, or mute the thread < https://github.com/notifications/unsubscribe-auth/ACKU8vkqb-kgSYet06hqZSnis3a3vqZrks5vbnMFgaJpZM4cTKMX

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/issues/25#issuecomment-478207708, or mute the thread https://github.com/notifications/unsubscribe-auth/AGbkCBEeTdhSP6r44UjD2W_BTik51DKkks5vbu8VgaJpZM4cTKMX .

akirmse commented 5 years ago

A PR would be great---I don't use Carthage. And if you can move it up to Swift 5.0, which just came out this week, even better.

On Sat, Mar 30, 2019 at 9:20 AM Steven Estes notifications@github.com wrote:

Sure. Open up the xcode project in the carthage folder, select the target in xcode in the left side navigation panel, and select the build settings tab. Then look through the build settings for Swift Compiler Language. You should see it’s set to Swift 3.0. If you change it to 4.2, that should allow carthage to compile with the latest xcode command line tools. I did this on a fork I created yesterday and verified it fixes the carthage issue. If you’d prefer, I can create a pull request.

Gracias

On Sat, Mar 30, 2019 at 12:59 AM Andrew Kirmse notifications@github.com wrote:

I'm using this with a Swift 5 project successfully, and in the podspec I see that it declares swift_version of 4.2. Can you tell me where the target needs to be changed?

On Fri, Mar 29, 2019 at 1:09 PM Steven Estes notifications@github.com wrote:

Looks like as of xcode 10.2, we can no longer compile Swift 3.0 if we have an app targeting 4.0 or later. Could you change the target to 4.0 or 4.2?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/issues/25, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ACKU8vkqb-kgSYet06hqZSnis3a3vqZrks5vbnMFgaJpZM4cTKMX

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/drtimcooper/LatLongToTimezone/issues/25#issuecomment-478207708 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AGbkCBEeTdhSP6r44UjD2W_BTik51DKkks5vbu8VgaJpZM4cTKMX

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/issues/25#issuecomment-478261055, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKU8rWEWzHmfSvkjEB8c9wN_-I_bxyxks5vb47OgaJpZM4cTKMX .

Tapestes commented 5 years ago

PR is in.

akirmse commented 5 years ago

Merged, and released new Cocoapod 1.1.6. Thanks!