search

drtimcooper / LatLongToTimezone

Lat/long to timezone mapper in Java. Does not require web services or data files - just pure Java or Swift.
MIT License
167 stars 33 forks source link

Add @objc to method signatures to make it work when used as a framework in objective-c #33

Closed zero0cool0 closed 4 years ago

zero0cool0 commented 5 years ago

I couldn't get TimezoneMapper to work when used via Cocaopods as framework in an Objective-c class until I read one particular comment in https://stackoverflow.com/questions/39215676/no-known-class-method-for-selector-when-using-static-swift-method-on-objective that you had to mark the method signatures with @objc to make it work.

akirmse commented 5 years ago

This file is autogenerated, so you would also need to change the generator code in https://github.com/drtimcooper/LatLongToTimezone/blob/master/src/main/java/com/skedgo/generator/TimeZoneMapperConverter.java

You have hundreds of whitespace changes; please revert these (preferably by running the autogenerator to re-create the file).

On Mon, Aug 26, 2019 at 6:35 AM Patrick notifications@github.com wrote:

I couldn't get TimezoneMapper to work when used in an Objective-c class until I read one particular comment in https://stackoverflow.com/questions/39215676/no-known-class-method-for-selector-when-using-static-swift-method-on-objective that you had to mark the method signatures with @objc https://github.com/objc to make it work.

You can view, comment on, or merge this pull request online at:

https://github.com/drtimcooper/LatLongToTimezone/pull/33 Commit Summary

  • Add @objc to make it work when used as a framework in objective-c

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/pull/33?email_source=notifications&email_token=AARJJ4UOVVMAQWCRWVVKDSTQGPL3XA5CNFSM4IPPXTWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHMGBCQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AARJJ4VHZUFJKEMXDRXHOVDQGPL3XANCNFSM4IPPXTWA .

zero0cool0 commented 5 years ago

Done. Notice when I ran the generator, it would format decimals with a comma instead of a dot, hence I tried to fix the number formatter inside the Util class, too.

akirmse commented 5 years ago

The Swift-related parts of this look OK. I'll let Tim comment on the number formatting. Allocating a new object every time a number is printed seems kind of suspect. There must be a more efficient way to set the separator.

On Wed, Aug 28, 2019 at 3:33 AM Patrick notifications@github.com wrote:

Done. Notice when I ran the generator, it would format decimals with a comma instead of a dot, hence I tried to fix the number formatter inside the Util class, too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/drtimcooper/LatLongToTimezone/pull/33?email_source=notifications&email_token=AARJJ4XSOCF666IJPEDZJLTQGZH67A5CNFSM4IPPXTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KVDIY#issuecomment-525685155, or mute the thread https://github.com/notifications/unsubscribe-auth/AARJJ4R2V5GH5AJHXEPUMWTQGZH67ANCNFSM4IPPXTWA .