drtimcooper / LatLongToTimezone

Lat/long to timezone mapper in Java. Does not require web services or data files - just pure Java or Swift.
MIT License
169 stars 33 forks source link

update to test to make it use JUnit Assertions rather than java assert.. #5

Closed iamrichardjones closed 5 years ago

iamrichardjones commented 8 years ago

…statements.

There is no build file so I am assuming that this is already set up your end. I see a pull request to add pom.xml and making the project maven compliant.

If you want me to make it gradle compliant or review the pom branch let me know. I am happy to do this and set up the build for the project. I just dont want to waste work by duplicating what someone has already done,

drtimcooper commented 8 years ago

Hi Richard @iamrichardjones , sorry for the delay in responding. You can catch me at tim@edval.com.au .

I don't know why JUnit assertions are better than the java assert (apologies for my ignorance), but I've merged your changes anyway. Except that I tried to follow the github instructions on merging and I don't think I did it in the proper way but the new asserts are in there.

I would like it if you can make it gradle compliant and/or review the pom branch. I'm not familiar with either Maven or Gradle so I'll probably just trust you to get it configured right.