search

drtshock / PlayerVaults

Player vaults for player players.
GNU General Public License v3.0
89 stars 123 forks source link

Permissions to over 100 vaults blowing everything up. #386

Closed andrewkm closed 4 years ago

andrewkm commented 5 years ago

Evnironment Paper: 1.13.2 Build 626 PlayerVaults compiled on: https://github.com/drtshock/PlayerVaults/commit/8008663c1f7d99824d350311818ee3e05c767514 (One build behind).

Give player permission: playervaults.amount.1 - correctly have access to /pv 1 playervaults.amount.10 - correctly have access to /pv 1 through /pv 10 playervaults.amount.99 - correctly have access to /pv 1 through /pv 99 playervaults.amount.100 - have access to only /pv 100 (/pv 1 through /pv 99 denied) playervaults.amount.101 - have access to only /pv 101 (/pv 1 through /pv 100 denied)

ArtelGG commented 5 years ago

Could you tell me your permissions plugin?

EDIT: I was able to reproduce this with my test server on 1.8.8 with my fork and the latest version of LuckPerms.

EDIT 2: My guess is it's an issue with a permission check, this is what I'm suspecting right now.

EDIT 3: As of right now I'd just say stick to lower numbers. I tried a couple of basic fixes and none of them took, I'll keep poking it at it though. Even if you're using vaults as a rank benefit nobody on this green earth is ever going to use more than 99 vaults.

andrewkm commented 5 years ago

We use LuckPerms. And yes, we actually do have people with 90+ vaults filled up ;)

andrewkm commented 5 years ago

The ins and outs of my server is irrelevant to the bug being discussed. It is in fact a bug. That is the topic.

drtshock commented 5 years ago

Yes I'm aware of this and confirm it. I'll be fixing this + the other NBT issue soon. Thanks for your patience.

andrewkm commented 4 years ago

Any updates on this @drtshock

CmdrKittens commented 4 years ago

Added configuration item max-vault-amount-perm-to-test with default value of 99 (matching current setup). Can be modified to whatever value you like.

andrewkm commented 4 years ago

@CmdrKittens your latest commits do not compile, likely due to: https://github.com/drtshock/PlayerVaults/commit/876c696e86fd8933522cf4db31360b46cfbac037 Compilation errors: https://pastebin.com/raw/p0H1LZ2P

CmdrKittens commented 4 years ago

@andrewkm It appears that Spigot 1.14 dropped org.json.simple from their API. It is still in the final compiled jar though, so I believe the plugin will work if you edit pom.xml line 56 to be 1.13 instead of 1.14 and build, even on 1.14 and 1.15

I will investigate further, but may or may not have the time today.

andrewkm commented 4 years ago

Confirmed compiling properly and bug tested/fixed. <3