search

drtshock / PlayerVaults

Player vaults for player players.
GNU General Public License v3.0
89 stars 123 forks source link

Please use HTTPS links in the repositories section of the pom #440

Closed Kas-tle closed 2 years ago

Kas-tle commented 2 years ago

Idea

Please use https links for the maven repos for sonatype and vault of the pom. Newer versions of Maven (3.8.1+) block non-https mirror repos by default. This makes it slightly annoying to build since these must be updated before building.

I canopen a PR myself if that would make your life easier, but I did not want to do anything that looks like contrib hunting since this is such a minor change.

Details

See https://maven.apache.org/docs/3.8.1/release-notes.html#cve-2021-26291 for more details

Specifically, the following lines should be updated: https://github.com/drtshock/PlayerVaults/blob/c2d9ce33183014b16b3b177530745725cbe76dd2/pom.xml#L75 https://github.com/drtshock/PlayerVaults/blob/c2d9ce33183014b16b3b177530745725cbe76dd2/pom.xml#L87

mbax commented 2 years ago

Oops! Didn't even notice! Thanks. https://github.com/drtshock/PlayerVaults/commit/5e406190d182c0426c915623180448f6d6ce7dcc