search

drtshock / Potato

If you fork this then you can say you forked a potato.
GNU General Public License v3.0
703 stars 2.54k forks source link

horseradish shall be added #138

Open chatasma opened 4 years ago

chatasma commented 4 years ago

well hopefully it will

Xeyame commented 4 years ago

what about #134 ?

drtshock commented 4 years ago

The implementation on this PR is better.

Xeyame commented 4 years ago

I think we should close #134 then

mdcfe commented 4 years ago

First of all, this PR lacks the essential horseradish image. This is required for any complete implementation of horseradish - you can see #134's approach here.

More importantly, this PR seeks to deny horseradish of its instrument-hood, which is absolute blasphemy to the highest degree. This denial is an affront to Potato-kind and should be treated accordingly.

I'm outraged that anyone could possibly consider this implementation to be even comparable to #134, let alone better!

Xeyame commented 4 years ago

I completely agree with the indepth explanation that @md678685 gave about why this PR is low quality, we need to have some quality guidelines. The missing image makes me think this PR is just for some hacktoberfest points, but considering @ThatOneTqnk also created the pervious (#134) PR, i don't think this is the case now

To be clear, its a high priority that we include images, else the support for horseradish is lacking and this might cause additional issues down the road. My suggestion would be however that we improve this PR, because #134 included some unwanted changes.

Ichbinjoe commented 4 years ago

Needs unit tested. -1