search

drtshock / Potato

If you fork this then you can say you forked a potato.
GNU General Public License v3.0
716 stars 2.56k forks source link

Added different ways the potato can be not delicious! #67

Closed hfreeb closed 9 years ago

blha303 commented 9 years ago

:+1:

anna-is-cute commented 9 years ago

Yeah, if this could be squashed and changed to NotDelicious, that'd be great.

Ichbinjoe commented 9 years ago

Squash your commits plz <3

drtshock commented 9 years ago

I'm not baked right now. Does that mean I'm not delicious? :(

blha303 commented 9 years ago

Quick tutorial for squashing commits? for reference

Ichbinjoe commented 9 years ago

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

hfreeb commented 9 years ago

Doing it now

blha303 commented 9 years ago

git rebase -i HEAD~5, change pick to squash on the second,third,fourth,fifth lines, leaving the first one as pick. Then close the editor, it'll prompt you to edit the commit messages. Tbh I just learned how to squash commits just then, thaaaaanks drtshock xoxo. Here's the diff I produced http://s.b303.me/Ppfb.diff

Ichbinjoe commented 9 years ago

Your commits will now be much more delicious. And clean. Which everyone likes.

anna-is-cute commented 9 years ago

Please put different enum values on different lines, as well.

hfreeb commented 9 years ago

Squashed them.

blha303 commented 9 years ago

:+1:

anna-is-cute commented 9 years ago

The JavaDocs in NotDeliciousReason are wrong. You've documented one of the enum values instead of the class. Ideally, all values and the class should be documented.

blha303 commented 9 years ago

:-1: :P

hfreeb commented 9 years ago

Uhh xD

blha303 commented 9 years ago

Just reopen it

anna-is-cute commented 9 years ago

Ideally, all values and the class should be documented.

hfreeb commented 9 years ago

Keeps on closing for some reason when I push and squash, will reopen again.

anna-is-cute commented 9 years ago

You're most likely clicking close and comment instead of comment.

Squashing shouldn't close it.

hfreeb commented 9 years ago

Fingers crossed that there is nothing else to change.