search

drtychai / penum

Parallelized enumeration tool for red team engagements and bug bounty programs.
18 stars 11 forks source link

Feat/add wafw00f #12

Closed cyrinux closed 4 years ago

cyrinux commented 4 years ago

Hmm i think this PR need some sed on the input file that got some too much dots after httprobe

drtychai commented 4 years ago

Thanks! I'll take a look at this (hopefully) this week ^^

From just a quick glance, there's some stuff I would prefer to not change (e.g., changing tab sizes to 2 chars from 4, single quotes to double quotes, etc.); just a personal coding preference. Once I take an in-depth look, I'll have more concrete notes to share :)

cyrinux commented 4 years ago

Yes, sorry, i got also my habit with some code formatter in my kakoune, i use black formatter btw for python i like a lot. Maybe we can try to use config like this in bottom of file, # vim: tabstop=4 expandtab shiftwidth=4 softtabstop=4 ?

On 09/04/20 12:30, bynx wrote:

Thanks! I'll take a look at this (hopefully) this week ^^

From just a quick glance, there's some stuff I would prefer to not change (e.g., changing tab sizes to 2 chars from 4, single quotes to double quotes, etc.); just a personal coding preference. Once I take an in-depth look, I'll have more concrete notes to share :)

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/drtychai/penum/pull/12#issuecomment-611712646

drtychai commented 4 years ago

@cyrinux Thank you for the PR! I finally got some free time and made the appropriate format changes, as well as a tool review. This looks good -- merging into development branch.

Also, I'll try to come up with a good vim formatting command for next time :)