drtyhlpr / rpi23-gen-image

Advanced Debian "stretch" and "buster" bootstrap script for RPi 0/1/2/3 and QEMU
GNU General Public License v2.0
305 stars 122 forks source link

11-apt.sh: Fixed APT_INCLUDES_LATE #187

Closed dkraemer closed 5 years ago

dkraemer commented 5 years ago

Hi!

When I set APT_INCLUDES_LATE to a comma-separated list of packages apt-get install failed, because it treats the package list as single argument.

APT_INCLUDES_LATE=net-tools,vim,mc,git,systemd-sysv,tmux,wpasupplicant,ufw

Output before my fix:

+ [ net-tools,vim,mc,git,systemd-sysv,tmux,wpasupplicant,ufw ]
+ echo net-tools,vim,mc,git,systemd-sysv,tmux,wpasupplicant,ufw
+ tr ,  
+ chroot_exec apt-get -qq -y install net-tools vim mc git systemd-sysv tmux wpasupplicant ufw
+ LANG=C LC_ALL=C DEBIAN_FRONTEND=noninteractive chroot /root/rpi23-gen-image/images/stretch-custom/build/chroot apt-get -qq -y install net-tools vim mc git systemd-sysv tmux wpasupplicant ufw
E: Unable to locate package net-tools vim mc git systemd-sysv tmux wpasupplicant ufw

Output after my fix:

+ [ net-tools,vim,mc,git,systemd-sysv,tmux,wpasupplicant,ufw ]  
+ echo net-tools,vim,mc,git,systemd-sysv,tmux,wpasupplicant,ufw
+ tr ,                                               
+ chroot_exec apt-get -qq -y install net-tools vim mc git systemd-sysv tmux wpasupplicant ufw
+ LANG=C LC_ALL=C DEBIAN_FRONTEND=noninteractive chroot /root/rpi23-gen-image/images/stretch-custom/build/chroot apt-get -qq -y install net-tools vim mc git systemd-sysv tmux wpasupplicant ufw                        
Extracting templates from packages: 100%                  
Preconfiguring packages ...

My environment:

root@vm-builder01:~/rpi23-gen-image# uname -a
Linux vm-builder01 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64 GNU/Linux
root@vm-builder01:~/rpi23-gen-image# lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.6 (stretch)
Release:    9.6
Codename:   stretch
burnbabyburn commented 5 years ago

nice find! i propably broke this while adding a bunch of quotation marks 👍

drtyhlpr commented 5 years ago

thanks for the fix