search

drublic / css-modal

A modal built with pure CSS, enhanced with JavaScript
https://drublic.github.io/css-modal
MIT License
1.82k stars 211 forks source link

Issue with page jumping when activating modal #101

Closed richie-y closed 10 years ago

richie-y commented 10 years ago

Edit: Original Title: Issue with page jumping when activating modal and images swapping from other modal light boxes when more than one are used on one page.

1)When opening modal, the page is jumping on both desktop and mobile views (more on mobile than on desktop)

2)When multiple modal light boxes are used on one page, when clicking on a thumbnail, the images are getting mixed up with each other.

Are any of these issues fixable? The issues can be seen on: http://www.thruair.co.uk

Thanks. Richard

anselmh commented 10 years ago

I guess your 1) is related to #32 and should be discussed over there. It would be great to have some more insight over there and maybe the demo link.

2) I can't confirm that with your given link. Can you assure that still happens and if, in which browser and OS and where exactly so we can try to reproduce this?

richie-y commented 10 years ago

I'm testing in both Google Chrome and Safari on OSX Maverick.

For an example of the issue: If a css-modal light box is activated via this URL: http://www.thruair.co.uk/#modal-pictures-proav and then some of the thumbnails are clicked, then images from the first css-modal light box on the page are triggered. Then if another css-modal light box is triggered without refreshing the page then main image from the previous lightbox is triggered.

I hope that this is a little more informative and that there is a solution. Thanks.

anselmh commented 10 years ago

Hi, I still can’t reproduce any jumping behavior on your page (tested Mavericks + Firefox, Chrome, Safari). Also your description talks about 'jumping', about 'wrongly shown images'—I can’t confirm them on your test page. If these issues still exist on your side and you can eliminate that it’s only a local problem on your computer, I'd be happy to see a short screencast so that we can know what you experience as issues. Otherwise it’s bit hard to debug as we don’t even know for sure what you experience.

drublic commented 10 years ago

@richie-y Is this issue still existing?