search

drublic / css-modal

A modal built with pure CSS, enhanced with JavaScript
https://drublic.github.io/css-modal
MIT License
1.82k stars 211 forks source link

inner media should have a max-width and max-height value #2

Closed anselmh closed 11 years ago

anselmh commented 11 years ago

See example: https://www.evernote.com/shard/s54/sh/a9e28f5c-a247-450d-a519-c74b2740b5d3/1ac0867ab5a6ab6eb2192a66c9b0db8a

drublic commented 11 years ago

max-width seems a good solution. max-height does not make sense I think because you can scroll the content-area. What do you think?

anselmh commented 11 years ago

True. Only max-width then.

anselmh commented 11 years ago

You also probably be a bit more flexible using this additional line of code:

.modal-content {
    max-height: 400px;
    max-height: 70vh;
}

Although vh should be 90vh to the whole modal I think. This 70vh is a quick fix for current base.