search

drublic / css-modal

A modal built with pure CSS, enhanced with JavaScript
https://drublic.github.io/css-modal
MIT License
1.82k stars 211 forks source link

video keeps playing after close #215

Open diomed opened 7 years ago

diomed commented 7 years ago

I open, then close modal with video, but I still hear the sound, so video continues to play. It's not really closed at all.

drublic commented 7 years ago

Thanks for the report. I am in the middle of a rewrite and will close this bug with the next version. Are you talking about HTML5 Video or a YouTube/Vimeo… iframe?

diomed commented 7 years ago

youtube/vimeo iframe - you can easily see it [hear it that is] in example, after you open it, and close it.

Zeaphon commented 5 years ago

I know this is probably a stretch and I guess this is mostly abandoned, but any progress on this? The example files are all still incorrectly linked and everything on the documentation seems to clash with whats actually in the zip I can download here.

I tried a lot of things and external scripts to get my modal to pause the video but so far no luck.

diomed commented 5 years ago

doesn't look abandoned. just 2 days ago he was updating dependencies.

perhaps he'll fix this issue as well.

drublic commented 5 years ago

Hello.

I guess this is due to some rewrite i did a couple of months back. Haven’t had the chance to finish it though. I try my best. PRs welcome.

Cheers.