search

drud / quicksprint

A basic toolkit to get people started with ddev and a Drupal codebase on macOS, Linux, or WIndows
Other
24 stars 16 forks source link

Remove doubled php installs from ubuntu and homebrew, fixes #161 #162

Closed rfay closed 4 years ago

rfay commented 4 years ago

Nightly builds have been failing due to apparent differences between the apt install of php and the brew install. Hopefully this minor change to the setup script will help.

rfay commented 4 years ago

I'm annoyed with how long the homebrew install takes, think I'll use the apt-get install and curl-install composer

rfay commented 4 years ago

This will also fix the problem in #161 of broken php upgrade on WIndows (and stays with php 7.3)

rfay commented 4 years ago

It ended up really complicated and fragile to get chocolatey to accept pinning to php7.3, so I just fixed all the testbots so they can handle 7.4. The only place this is actually used is in the initial composer install.

rfay commented 4 years ago

Yay, we might have it! If you're ok with this @mradcliffe we'll get it in.

mradcliffe commented 4 years ago

Yes, this works for me. Did you end up fixing something manually on the buildkite machines to get it to pass on Windows? I don't see any change that would affect that.

rfay commented 4 years ago

Yes, there is apparently a bug in chocolatey that prevents major version upgrades to php from succeeding. So I did the manual process to remove the old php and install the new.