drud / quicksprint

A basic toolkit to get people started with ddev and a Drupal codebase on macOS, Linux, or WIndows
Other
24 stars 16 forks source link

Packaging script adds Brian's irc/ide containers into drupal8/.ddev #5

Closed mradcliffe closed 6 years ago

mradcliffe commented 6 years ago

Feature Request:

Brian has extra containers as part of the feature set from dev desktop of including an editor, irc client, etc...

New contributors who do not have an IDE or preferred editor are able to have a nice experience editing files and getting on IRC. We still have and support IRC users (#drupal-contribute has core contributors actively using it to discuss and collaborate), but we are also mentoring during core sprints on Drupal Slack.

I've created the ddev-compatible YAMLs already so I can probably submit a PR.

What you expected to happen:

mradcliffe commented 6 years ago

I think the main complexity here is the implementation of either modifying the ddev_images tarball to keep all images in the same place.

rfay commented 6 years ago

I don't think the ddev_docker_images tarball has to be the only tarball. There can be more than one. The ddev_docker_images tarball comes from the build process on Circle. The images for other things can come from elsewhere.

rickmanelius commented 6 years ago

A question that was raised while sitting with @mradcliffe at Midcamp. We are not presuming this repo to be the source of truth and we've reached out to @briangilbert to see if it makes sense to pull in any his work here or have this work pulled out to his repo. Just noting this as something while we keep working in this sandbox! And that might affect whether or not we proceed here. @mradcliffe looks like he has working yml files and it doesn't harm us to get them in here as well.

mradcliffe commented 6 years ago

Brian mentioned on 2018.03.11 that probably not this repo, but he wanted to catch up in the morning (2018.03.12 for him) and talk further. So that's probably around 15:00 CST 2018.03.11.

BrianGilbert commented 6 years ago

I'm happy to contribute here, After talking to @rfay it seems like a fair bit of what I have been working on is already done here.. there are some pretty big savings in file size that can be made though.. I will open a separate ticket about that.

rickmanelius commented 6 years ago

Excellent! Ultimately, whatever helps set us best up for Drupalcon NA is what works for me. If this needs to have a separate home after, more than open to discuss what makes sense.

rfay commented 6 years ago

Just responding to the title here "Packaging script adds Brian's irc/ide containers into drupal8/.ddev" - we would not want to put any containers into .ddev; we load them into docker via docker load. Additional images can be added to a new tarball of images, and loaded (optionally?) on install.

mradcliffe commented 6 years ago

This was completed in #12