drud / quicksprint

A basic toolkit to get people started with ddev and a Drupal codebase on macOS, Linux, or WIndows
Other
24 stars 16 forks source link

[#42] Changed webserver ports to 8080 and 8443 to avoid collisions with host services, fixes #42 #52

Closed BrianGilbert closed 6 years ago

BrianGilbert commented 6 years ago

Fixes #42

Also added https url to output of start_clean and README.txt

rfay commented 6 years ago

This is going to turn out OK, but I haven't manually tested yet, and want to wait until it's rebased on top of the circleci tests. Maybe we can even add a circleci test that actually tests the port.

rfay commented 6 years ago

Just needs rebase and I can manually test in the morning. If you authorize me, I can also pull it if it's good.

BrianGilbert commented 6 years ago

@rfay happy for you to merge when ready

rfay commented 6 years ago

Manually tested on macOS, looks good. Will get it in and test on Windows as in the windows PR tests after rebase.