search

drud / quicksprint

A basic toolkit to get people started with ddev and a Drupal codebase on macOS, Linux, or WIndows
Other
24 stars 16 forks source link

Attempts to check for other supported versions of Windows #92

Closed mradcliffe closed 6 years ago

mradcliffe commented 6 years ago

Not sure if this will work exactly as I'm not on Windows.

rfay commented 6 years ago

We do have to have a way to test this, at least trivially testing manually.

mradcliffe commented 6 years ago

Looks like it needs work.

rfay commented 6 years ago

For testing, you may want these images: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ - Parallels makes this super easy (for those on mac). I just grabbed win7, will try to get win8 too, but probably won't have time to do any testing.

rfay commented 6 years ago

Windows 7 (32-bit) reports with uname (and thus $OS) MINGW32_NT-6.1 Windows 7 (64-bit) reports MINGW64_NT-6.1 Windows 8.1 reports with uname MINGW64_NT-6.3 Windows 10 reports MINGW64_NT-10.0

So basically, we can mostly support MINGW64_NT

The Windows 7 instance from microsoft tools though is apparently i386; docker toolbox requires x64. So nobody who comes to a sprint with a 32-bit machine is going to work out I don't think.

And I can't come up with a way to run Win7 64-bit with nested virtualization, so skunked there.

mradcliffe commented 6 years ago

Yep, that's what I was trying to target, but I probably messed up the grep regex.

Let's see about this one, which tries to simplify the uname string to just MINGW64 so any random Windows version update doesn't bite us.

mradcliffe commented 6 years ago

So, maybe the wildcard approach isn't detecting correctly on buildkite, but using grep is fine?

mradcliffe commented 6 years ago

ci/circleci: normal_build_and_test Expected — Waiting for status to be reported

I think circleci/github is stuck. The job completed successfully.

rfay commented 6 years ago

I didn't understand why you gave up on https://github.com/drud/quicksprint/pull/92/commits/8f43e1cc503444ecb55862681b7aaa9a4046f1a6 ? Because the docker toolbox failure? that happened long before the install.sh AFAICT (It was cancelled by your next commit... which seemed to have an error in it?)

Restarting those builds for 8f43e1cc503444ecb55862681b7aaa9a4046f1a6

mradcliffe commented 6 years ago

I waited for all the builds to finish (and the build kite ones failed for both ) before reverting 8f43e1c . And I swear it had a red x yesterday along with all the builds of d585a79. :|

mradcliffe commented 6 years ago

I think it looks good. circleci/github seems to be stuck on expecting a status update when everything's finished again.

rfay commented 6 years ago

The overall failure to report of the main job (normal_build_and_test) seems to be just some kind of Circleci bug, but yeah, looks to like everything is fine.

mradcliffe commented 6 years ago

I'm ready for this, but I can't merge because of the circleci status check.