search

drud / style.ddev.com

Apache License 2.0
0 stars 2 forks source link

Error and loading states #4

Open andrew-c-tran opened 6 years ago

andrew-c-tran commented 6 years ago

The UI will regularly fall into a state where actions are happening and an indicator that work is being done needs to be shown. A loading spinner or other type of indicator is needed.

The UI will also occasionally fall into a state where an action has failed, or either the UI or the CLI has experienced some sort of error. Defining error prompts and other indicators on how to display the correct error information is needed.

andrew-c-tran commented 6 years ago

Initial proposal for loading state:

grey overlay with a loading spinner and current state to the right. in card view, this will overlay the card processing things, in modals it will overlay the modal.

example: screen shot 2017-12-12 at 10 24 18 am

rickmanelius commented 6 years ago

Crap I missed this earlier re:full view versus only covering an individual card. Disregard that comment. As for the elements/colors, I think we need to definitely address color contrast because things like the "Creating ddev-router" wash out a bit. That said, it's easy to note the deficiency and hard to address the correction because I know we may need additional support from a design resource to make more definitive recommendations.

TL;DR I like the strategy but work needs to be done on the design aspects of colors/sizing/placement.

cyberswat commented 6 years ago

We really need to commit to getting the efforts from the style guide wrapped into this kind of work. I understand that it's a bit of a pain because the people involved are a bit isolated, but it feels like something we should fix.

andrew-c-tran commented 6 years ago

We should have the error and loading states today correct? We can definitely pull those in

On Dec 13, 2017 8:13 AM, "Kevin Bridges" notifications@github.com wrote:

We really need to commit to getting the efforts from the style guide wrapped into this kind of work. I understand that it's a bit of a pain because the people involved are a bit isolated, but it feels like something we should fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/drud/style.drud.com/issues/4#issuecomment-351420031, or mute the thread https://github.com/notifications/unsubscribe-auth/AIi5a3Nu6L-csMNI46PyKnv3hyhBNYo_ks5s_-l2gaJpZM4Qr1Oy .

rickmanelius commented 6 years ago

Related to https://github.com/drud/ddev-ui/issues/8