search

drufat / triangle

Python bindings to the triangle library
GNU Lesser General Public License v3.0
224 stars 53 forks source link

Warning during installation: comparison of integers of different signs: 'int' #20

Closed boustrephon closed 4 years ago

boustrephon commented 6 years ago

I noticed these two warnings during installation. Is there any reason to be concerned about these?

gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/Users/andrew/miniconda3/include -arch x86_64 -I/Users/andrew/miniconda3/include -arch x86_64 -DVOID=int -DREAL=double -DNO_TIMER=1 -DTRILIBRARY=1 -DANSI_DECLARATORS=1 -Ic -I/Users/andrew/miniconda3/include/python3.6m -c c/triangle.c -o build/temp.macosx-10.7-x86_64-3.6/c/triangle.o
c/triangle.c:3949:17: warning: comparison of integers of different signs: 'int'
      and 'unsigned long' [-Wsign-compare]
  if (alignment > sizeof(VOID *)) {
      ~~~~~~~~~ ^ ~~~~~~~~~~~~~~
c/triangle.c:4349:16: warning: comparison of integers of different signs: 'int'
      and 'unsigned long' [-Wsign-compare]
      (trisize < 6 * sizeof(triangle) + sizeof(int))) {
       ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
drufat commented 4 years ago

Those warnings are from the underlying C library https://www.cs.cmu.edu/~quake/triangle.html. I have not made any modifications to it - I only maintain the Python wrapper.