search

drufat / triangle

Python bindings to the triangle library
GNU Lesser General Public License v3.0
229 stars 53 forks source link

Issue with License / conda forge submission #56

Open rbeucher opened 3 years ago

rbeucher commented 3 years ago

Hi @drufat,

@badlands-model uses your wrapper and I would like to thank you because it has been very useful. I am trying to create a conda binary for https://github.com/badlands-model/badlands and I have submitted a python-triangle recipe to conda-forge in the process. You can see the PR here https://github.com/conda-forge/staged-recipes/pull/12951.

The PR is blocked because we are facing some issues regarding the License you chose for your package. I am just going to quote @mbargul on this:

I checked the licenses (which we should do, being (re-) distributors) and it looks rather disappointing :(. The creator of the Python wrapper chose a LGPL for their code but the underlying library has a custom non-commercial license. Since -- AFAIK -- (L)GPL does not work with imposing additional restrictions (such as prohibiting commercial use), it is not possible to distribute both the wrapper as well as Triangle together. The wrapper also vendors (i.e., includes and not just dynamically links to) Triangle, meaning any form of it (which also includes their PyPI distributions, esp. the wheels) does not have a valid license for distribution.

I understand that this might not be a priority for you but I also do thing it would be good to resolve this. I have not really looked in details but I believe that an MIT license could work.

Thanks!

Romain

stoiver commented 2 years ago

Hi @drufat, I would just like to support @rbeucher's request regarding the licencing of your wrapper.

Like @rbeucher we have found your wrapper to be very useful in our flood and tsunami modelling package anuga, https://github.com/anuga-community/anuga_core. And like @rbeucher I was in the process of preparing anuga as a conda-forge package and ran into the licencing problem with your wrapper.

I have found another project which wraps triangle, https://github.com/inducer/meshpy which is available on conda-forge and so seems to have resolved the licencing problem. That package uses an MIT licence for the wrapping code and distributing the triangle code.

It would be great if you considered changing your licence to allow uploading to conda-forge.

Once again, great job,

Steve