search

drugan / commerce_xquantity

Drupal Commerce 2.x contrib module. Allows to set quantity field's default_value, step, min, max, prefix and suffix on a form display widget. Also, the commerce product variation stock can be managed if the appropriate submodule is enabled.
5 stars 2 forks source link

Modified README.md a bit #1

Open kartagis opened 5 years ago

kartagis commented 5 years ago

README.md contained some typos, I corrected them.

drugan commented 5 years ago

Thank you!

Yes, English language is not the best part of me :). I have Grammarly installed but as always don't have enough time to parse my texts properly. And mostly they seem to me quite correct though obviously they are not.

As for the patch it would be better if you'd open an issue on DO so, I can give you a commit credit. The Github repos of all my modules are just mirrors exactly for the purpose to expose a module's help README.md file (and may be other files) for potential users as a simple way to understand what the module does.

Before you post the patch on DO please make some changes. First, then go the... hunch is not needed because the readmehelp module markdown parser requires a WORD or a blank line to be before the anchor start, otherwise it results in a text and anchor become joined on a Drupal site: no-ws

I ignore the Drupal standards line exceed 80 chars.. warning for my README.md files. Yes, theoretically it is possible to modify a parser so it works absolutely the same as the github.com markdown parser but... Let us hope that someone else will suggest a patch for this part :).

Additionally, I'd recommend to run git diff command before creating a patch as it helps to discover trailing white spaces: trailing-ws