drugpl / bbq

Object oriented acceptance testing using personas.
MIT License
92 stars 9 forks source link

Remove rails' url helpers support #17

Closed sevos closed 12 years ago

sevos commented 13 years ago

Rails' URL helpers are part of user's application. Therefore it should not be accessible from integration test suite, where plain paths should be used to keep routes be tested within integration test suite.

Remove rails' url helpers support

ryanong commented 13 years ago

:/ I disagree I think you should just test routes separately from acceptance test. Imagine the amount of code management that would be required

paneq commented 13 years ago

I agree that test user should not know about all application routes. Simply go to "/" or "/admin" and interact with the app to achive the desired effect.

sevos commented 13 years ago

@ryanong: examples?

I found another problem: Devise support requires knowledge about rails routes. I didn't look deeply into that but anyway I'd move out the devise support into extension (user would need to require 'bbe/devise').

ryanong commented 13 years ago

I use the helpers a in a few places in my code. Maybe I shouldn't but it simplifies my life when rapid prototyping and I don't have time to follow all good coding protocol.

paneq commented 13 years ago

@ryanong - thanks to ruby open classes you can always include anything you want even if we remove it.

ryanong commented 13 years ago

lol, yea i know I was just thinking about that. Ignore what I said.

jdudek commented 12 years ago

Pull request was merged, so I'm closing this issue.