Closed mlomnicki closed 12 years ago
there are no tests that session is reseted between tests. there are no tests for usage without session pool.
good start imho but requires more work :) 31-01-2012 18:18 uytkownik "Micha omnicki" < reply@reply.github.com> napisa:
hi fellow haters,
Please review and tell me what you think. I'm not very satisfied with that approach although I see no way to do it better
You can merge this Pull Request by running:
git pull https://github.com/mlomnicki/bbq session_pool
Or you can view, comment on it, or merge it online at:
https://github.com/drugpl/bbq/pull/22
-- Commit Summary --
- session pool integration tests
-- File Changes --
A test/support/driver_factory.rb (28) M test/unit/bbq_rspec_test.rb (45) M test/unit/bbq_test_unit_test.rb (48)
-- Patch Links --
https://github.com/drugpl/bbq/pull/22.patch https://github.com/drugpl/bbq/pull/22.diff
Reply to this email directly or view it on GitHub: https://github.com/drugpl/bbq/pull/22
well spotted :) hope you like it better now
hi fellow haters,
Please review and tell me what you think. I'm not very satisfied with that approach although I see no way to do it better