search

drugpl / bbq

Object oriented acceptance testing using personas.
MIT License
92 stars 9 forks source link

Update rpsec matchers to use non-deprecated methods #40

Closed eugie closed 9 years ago

eugie commented 9 years ago

When we upgraded RSpec to RSpec 3.0, we started getting deprecation warnings in our specs because of bbq.

Deprecation Warnings:

`failure_message_for_should_not` is deprecated. Use `failure_message_when_negated` instead. Called from /Users/pivotal/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/bbq-0.2.1/lib/bbq/rspec.rb:53:in `block in <module:RSpecMatchers>'.

`failure_message_for_should` is deprecated. Use `failure_message` instead. Called from /Users/pivotal/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/bbq-0.2.1/lib/bbq/rspec.rb:44:in `block in <module:RSpecMatchers>'.

`match_for_should_not` is deprecated. Use `match_when_negated` instead. Called from /Users/pivotal/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/bbq-0.2.1/lib/bbq/rspec.rb:34:in `block in <module:RSpecMatchers>'.

`match_for_should` is deprecated. Use `match` instead. Called from /Users/pivotal/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/bbq-0.2.1/lib/bbq/rspec.rb:24:in `block in <module:RSpecMatchers>'.

We updated the RSpecMatcher module in bbq to use the updated syntax.

mostlyobvious commented 9 years ago

Thank you for PR. I'll look more closely in the following days what does it take to merge this, https://github.com/drugpl/bbq/pull/39 an have rspec 2.x working as well.