Open cintoSunny opened 2 years ago
@cintoSunny this LGTM . This metric would be helpful, plus it would great if we can draft a proposal for all the monitoring metrics and start implementing.
Thanks !
cc @himanshug @nishantmonu51
Sure. Will do that. I am just writing the list of metrics offline. Will share when done. I am just trying to go through the code, will take some time
In the current Druid operator, some Kubernetes related failures are not tracked as errors in metrics. I am planning to add those errors as well. This is the approach I am taking. Wanted to check with you before making the changes. Let me know what you think.
One of the errors I see is raised from
interface.go
I am planning to have a separate pkg - metrics for monitoring. Here is what I did:
And then added
metrics.DruidPlatformError.Inc()
to theinterface.go
. Let me know what you think.Thanks again for all the help.