Open CodingParsley opened 2 years ago
@AdheipSingh Thank you ❤️
@AdheipSingh Thank you ❤️
ill run this locally and test, cc @nishantmonu51 for approval to run CI.
just a question, does this PR work if you specify image for all nodeSpecs and also for individual nodeSpec ?
@xvrl can you approve this PR to run the CI. :)
just a question, does this PR work if you specify image for all nodeSpecs and also for individual nodeSpec ?
Yes, this PR does not change the image of the container
@xvrl Maybe another look? 🙏
Description
It provides lightweight solution to run some easy startup commands before running druid script For example, for debugging purpose if we want to check if an environment variable has been set before the druid script was run, we can set
The container will run
sh -c "echo ${ENV} >> file && /bin/run-druid.sh {nodetype}
Another example use case is that if we need to source a file before running the druid script, it provides a lightweight solution to do that - we can set
And the container will run
sh -c "source ${filename} && /bin/run-druid.sh {nodetype}
If
entryArg
is not set, the container will act the same as before, thus preserving backward compatibility. The PR also added variabledruidScript
to customize druid script path.This PR has:
Key changed/added files in this PR
entryArg
druidScript