search

druid-io / druid-operator

Druid Kubernetes Operator
Other
205 stars 93 forks source link

Service annotations are not getting applied during service creation #292

Open blockcoder1 opened 2 years ago

blockcoder1 commented 2 years ago

Hello Team,

We have a requirement when in we have to add Prometheus related annotations inside service metadata. Due to some reason this configurations are not getting reflected. Inside druid CR we have provision to provide annotations for our service 

      services:
        - metadata:
            annotations:
              prometheus.io/scrape: "true"
              prometheus.io/port: "8092"
              prometheus.io/path: <Path>

I think this is not handled inside code. Any help is highly appreciated.

AdheipSingh commented 2 years ago

@blockcoder1 yeah service annotations isnt being added by the operator.

We can add this in the makeService(). Feel free to send a PR.

blockcoder1 commented 2 years ago

@AdheipSingh sure will do that