Fix-320-objectmeta-crd - Githubissues

druid-io / druid-operator

Druid Kubernetes Operator

Other

205 stars 93 forks source link

Fix-320-objectmeta-crd #321

Closed AdheipSingh closed 1 year ago

AdheipSingh commented 1 year ago

Fixes #320

Description

with crd conversion objectmeta field goes out.

This PR has:

[x] been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
[x] been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added documentation for new or modified features or behaviors.

Key changed/added files in this PR

MyFoo
OurBar
TheirBaz

AdheipSingh commented 1 year ago

@xvrl can you help in merging this one. Breaking master fix.

xvrl commented 1 year ago

@AdheipSingh I'm not familiar enough with the operator codebase to review this. @nishantmonu51 can you help find someone to review this?

jwitko commented 1 year ago

Any chance for a review/merge on this ? seems to be breaking basic functionality

churromorales commented 1 year ago

is this project no longer maintained?

AdheipSingh commented 1 year ago

@churromorales @jwitko https://github.com/druid-io/druid-operator/issues/329

AdheipSingh commented 1 year ago

@jwitko @churromorales the repo and the codebase will be maintained.