druid-io / druid-operator

Druid Kubernetes Operator
Other
205 stars 92 forks source link

RollingDeploy does not work when considering StatefulSets of historical tiers #348

Open aruraghuwanshi opened 1 month ago

aruraghuwanshi commented 1 month ago

In the current Druid Operator, when rollingDeploy is enabled, the expectation is that the nodes will restart one at a time in the pre-defined order. In the case where we have multiple tiers within historicals, that is equivalent to having multiple Stateful Sets of NodeType historical.

The Operator's deploy loop of allNodeSpecs does not stop to check whether each historical tier Statefulset is deployed and ends up deploying all historical tiers one after the other without waiting for a full deployment of the previous StatefulSet.

Here is a PR that would solve the issue.