search

druid-io / druid-operator

Druid Kubernetes Operator
Other
204 stars 92 forks source link

Rename Ingress Naming Convention #95

Open AdheipSingh opened 3 years ago

AdheipSingh commented 3 years ago

https://github.com/druid-io/druid-operator/blob/master/pkg/apis/druid/v1alpha1/druid_types.go#L247

Here json:"ingress,omitempty" should be renamed to json:"ingressSpec,omitempty"`, since this expecting a spec, all other objects with spec follow this naming convention.

himanshug commented 3 years ago

since this expecting a spec, all other objects with spec follow this naming convention.

well, there are many e.g. HPAutoScaler *autoscalev2beta1.HorizontalPodAutoscalerSpecjson:"hpAutoscaler,omitempty"``

for now, I wouldn't worry about it too much.

AdheipSingh commented 3 years ago

i see, my only confusion was when i mention ingress

ingress:
  spec:
    ...

this adds confusion since we dont need to pass in spec, same goes for HPA one too this should be

ingressSpec:
  ...