Linting in travis.ci using flake8

druid-io / pydruid

A Python connector for Druid

Other

509 stars 200 forks source link

Linting in travis.ci using flake8 #111

Closed mistercrunch closed 6 years ago

mistercrunch commented 6 years ago

Also:

linting the whole package
fixing travis build
removed non deterministic unit test that was failing, the seems very wrong so I just deleted it instead of fixing it. It asserts on the equality of dictionary instead of doing a deep compare and has wrong assumptions on the data types its handling. Removing so that we can get the build running again.

betodealmeida commented 6 years ago

Cool! One thing I have in my .vimrc is:

au BufWrite *.py :Autoformat

And I have https://github.com/Chiel92/vim-autoformat installed. This way whenever I save a Python file it will run autopep8 on them. I usually disable when I'm working on other people's code, though, since it introduces too many changes.

mistercrunch commented 6 years ago

I have vimtastic setup with pylint and it's very neat too. Much recommended