search

druid-io / pydruid

A Python connector for Druid
Other
509 stars 200 forks source link

Allow config of http client implementation #163

Closed wjdecorte closed 5 years ago

wjdecorte commented 5 years ago

Issue #162 Add the ability to use a different http client such as the curl_httpclient which can be faster. An optional parameter was added to the class init which defaults to None, meaning using the default simple_httpclient. To use curl_httpclient, set the parameter http_client to the value "tornado.curl_httpclient.CurlAsyncHTTPClient". AsyncHTTPClient.configure is then called with the appropriate http_client value before instantiating AsyncHTTPClient.

mistercrunch commented 5 years ago

LGTM, but conflicts... please rebase

wjdecorte commented 5 years ago

Thanks, I apologize for the issues. I'm rather new to submitting PR's for others repos. I believe I have rebased appropriately. I resolved the conflicts and executed the tests successfully. I'm not sure if I need to do anything else. Please let me know if I do.

mistercrunch commented 5 years ago

Something went wrong with your rebase, look at the commit list :(

wjdecorte commented 5 years ago

I'm not surprised by that. My apologies, it is all new to me. Any suggestions for fixing the rebase would be appreciated. I'll take a look at the commit list, but frankly, I'm not sure what I'm looking for.

wjdecorte commented 5 years ago

Ok, I think I resolved the issue with the rebase. Sorry about that. It was a silly mistake and I should have caught it. Let me know if it is ok now.

mistercrunch commented 5 years ago

I think you still have unwanted commits in this PR.

wjdecorte commented 5 years ago

Sorry. I'm not sure what I did wrong. I have created a new branch from the latest master of this repo. I updated the code, tested and ran automated tests. Should I create a new PR? I wanted to confirm before doing so.

New branch

mistercrunch commented 5 years ago

@wjdecorte , you can just force push on the original branch name, I'd

git checkout ok_branch
git branch -D old_branch
git checkout -b old_branch
git push origin old_branch -f
wjdecorte commented 5 years ago

@mistercrunch Thank you, sir! I did exactly what you listed and hopefully (fingers crossed) it is correct this time. I really appreciate your help and patience!