search

druid-io / pydruid

A Python connector for Druid
Other
506 stars 194 forks source link

[dbapi] Fixing type ordering #172

Closed john-bodley closed 4 years ago

john-bodley commented 4 years ago

Similar to https://github.com/druid-io/pydruid/pull/171 this PR ensures that the type check for the more restrictive boolean occurs before the check for numeric type as isinstance(True, (int, float)) evaluates to True.

to: @betodealmeida @mistercrunch

mistercrunch commented 4 years ago

Oh one comment, I didn't think order matter much here, you could add a code comment noting this and how it should be ordered.

mistercrunch commented 4 years ago

Build is failing, otherwise LGTM, maybe we should setup the same commit hooks as Superset...

john-bodley commented 4 years ago

@mistercrunch I've addresses the build issues.