search

druid-io / pydruid

A Python connector for Druid
Other
506 stars 194 forks source link

[dbapi] Fix empty parameter check #174

Closed john-bodley closed 4 years ago

john-bodley commented 4 years ago

This PR is a refinement of https://github.com/druid-io/pydruid/pull/171 where the check for parameters is loosened to be anything which is falsy. This is needed as libraries like Pandas passes an empty dictionary (as opposed to None) if no parameters are defined.

to: @betodealmeida @mistercrunch

john-bodley commented 4 years ago

@betodealmeida or @mistercrunch would you be able to take a look at this?