druid-io / pydruid

A Python connector for Druid
Other
506 stars 194 forks source link

[ci] Adding tox #190

Closed john-bodley closed 4 years ago

john-bodley commented 4 years ago

This PR adds tox a common Python testing environment. Note I also added a requirements.txt file (used in tox) which freezes all the dependencies (including the extras) which means we're no longer skipping certain tests or mocking the Tornado logic.

In future PRs I plan to:

to: @betodealmeida @mistercrunch

MSadeghzadehG commented 4 years ago

I can't see how these changes could resolve missing tabulate module problem?

john-bodley commented 4 years ago

@MSadeghzadehG if you look in requirements.txt (which in autogenerated from requirements.in using pip-compile) you can see a line item for the tabulate package.

MSadeghzadehG commented 4 years ago

@john-bodley Nice.

john-bodley commented 4 years ago

@mistercrunch I addressed your comment.

SongYunSeop commented 4 years ago

Is it still working in progress?

john-bodley commented 4 years ago

@SongYunSeop this PR is ready for review.

mistercrunch commented 4 years ago

neato