search

druid-io / pydruid

A Python connector for Druid
Other
506 stars 194 forks source link

fix broken build #221

Closed villebro closed 4 years ago

villebro commented 4 years ago

In a recent PR #218 aiming to exclude avoid accidentally packaging unwanted files in the build (secrets, venv, .tox etc), more strict inclusion rules were put in place. However, the PR also broke the build bu not including all important files.

This fix has been tested locally to work by:

Closes #220

mistercrunch commented 4 years ago

I don't understand why .git/ .tox/ venv/ [stil] get picked up when I run python setup.py sdist

villebro commented 4 years ago

Very strange:

$ ls .tox
black/  flake8/ isort/  log/
$ python setup.py sdist
/Users/ville/src/pydruid/venv/lib/python3.7/site-packages/setuptools/dist.py:454: UserWarning: Normalizing '0.999.0dev' to '0.999.0.dev0'
  warnings.warn(tmpl.format(**locals()))
running sdist
running egg_info
writing pydruid.egg-info/PKG-INFO
writing dependency_links to pydruid.egg-info/dependency_links.txt
writing entry points to pydruid.egg-info/entry_points.txt
writing requirements to pydruid.egg-info/requires.txt
writing top-level names to pydruid.egg-info/top_level.txt
reading manifest file 'pydruid.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.txt' under directory 'docs'
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
writing manifest file 'pydruid.egg-info/SOURCES.txt'
running check
creating pydruid-0.999.0.dev0
creating pydruid-0.999.0.dev0/.eggs
creating pydruid-0.999.0.dev0/.eggs/pytest_runner-5.2-py3.7.egg
creating pydruid-0.999.0.dev0/docs
creating pydruid-0.999.0.dev0/docs/figures
creating pydruid-0.999.0.dev0/docs/source
creating pydruid-0.999.0.dev0/pydruid
creating pydruid-0.999.0.dev0/pydruid.egg-info
creating pydruid-0.999.0.dev0/pydruid/db
creating pydruid-0.999.0.dev0/pydruid/utils
creating pydruid-0.999.0.dev0/tests
creating pydruid-0.999.0.dev0/tests/db
creating pydruid-0.999.0.dev0/tests/utils
copying files to pydruid-0.999.0.dev0...
copying CHANGELOG.md -> pydruid-0.999.0.dev0
copying LICENSE -> pydruid-0.999.0.dev0
copying MANIFEST.in -> pydruid-0.999.0.dev0
copying README.md -> pydruid-0.999.0.dev0
copying RELEASE.md -> pydruid-0.999.0.dev0
copying requirements-dev.txt -> pydruid-0.999.0.dev0
copying requirements.txt -> pydruid-0.999.0.dev0
copying setup.cfg -> pydruid-0.999.0.dev0
copying setup.py -> pydruid-0.999.0.dev0
copying .eggs/pytest_runner-5.2-py3.7.egg/ptr.py -> pydruid-0.999.0.dev0/.eggs/pytest_runner-5.2-py3.7.egg
copying docs/Makefile -> pydruid-0.999.0.dev0/docs
copying docs/figures/avg_tweet_length.png -> pydruid-0.999.0.dev0/docs/figures
copying docs/figures/twitter_graph.png -> pydruid-0.999.0.dev0/docs/figures
copying docs/source/conf.py -> pydruid-0.999.0.dev0/docs/source
copying docs/source/index.rst -> pydruid-0.999.0.dev0/docs/source
copying pydruid/__init__.py -> pydruid-0.999.0.dev0/pydruid
copying pydruid/async_client.py -> pydruid-0.999.0.dev0/pydruid
copying pydruid/client.py -> pydruid-0.999.0.dev0/pydruid
copying pydruid/console.py -> pydruid-0.999.0.dev0/pydruid
copying pydruid/query.py -> pydruid-0.999.0.dev0/pydruid
copying pydruid.egg-info/PKG-INFO -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid.egg-info/SOURCES.txt -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid.egg-info/dependency_links.txt -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid.egg-info/entry_points.txt -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid.egg-info/requires.txt -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid.egg-info/top_level.txt -> pydruid-0.999.0.dev0/pydruid.egg-info
copying pydruid/db/__init__.py -> pydruid-0.999.0.dev0/pydruid/db
copying pydruid/db/api.py -> pydruid-0.999.0.dev0/pydruid/db
copying pydruid/db/exceptions.py -> pydruid-0.999.0.dev0/pydruid/db
copying pydruid/db/sqlalchemy.py -> pydruid-0.999.0.dev0/pydruid/db
copying pydruid/utils/__init__.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/aggregators.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/dimensions.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/filters.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/having.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/postaggregator.py -> pydruid-0.999.0.dev0/pydruid/utils
copying pydruid/utils/query_utils.py -> pydruid-0.999.0.dev0/pydruid/utils
copying tests/test_async_client.py -> pydruid-0.999.0.dev0/tests
copying tests/test_client.py -> pydruid-0.999.0.dev0/tests
copying tests/test_query.py -> pydruid-0.999.0.dev0/tests
copying tests/db/test_cursor.py -> pydruid-0.999.0.dev0/tests/db
copying tests/db/test_rows_from_chunks.py -> pydruid-0.999.0.dev0/tests/db
copying tests/utils/test_aggregators.py -> pydruid-0.999.0.dev0/tests/utils
copying tests/utils/test_dimensions.py -> pydruid-0.999.0.dev0/tests/utils
copying tests/utils/test_filters.py -> pydruid-0.999.0.dev0/tests/utils
copying tests/utils/test_having.py -> pydruid-0.999.0.dev0/tests/utils
copying tests/utils/test_query_utils.py -> pydruid-0.999.0.dev0/tests/utils
Writing pydruid-0.999.0.dev0/setup.cfg
Creating tar archive
removing 'pydruid-0.999.0.dev0' (and everything under it)
mistercrunch commented 4 years ago 
09:11 $ python setup.py sdist | head -n 30
/Users/max/code/pydruid/envpy3/lib/python3.7/site-packages/setuptools/dist.py:454: UserWarning: Normalizing '0.999.0dev' to '0.999.0.dev0'
  warnings.warn(tmpl.format(**locals()))
running sdist
running egg_info
writing pydruid.egg-info/PKG-INFO
writing dependency_links to pydruid.egg-info/dependency_links.txt
writing entry points to pydruid.egg-info/entry_points.txt
writing requirements to pydruid.egg-info/requires.txt
writing top-level names to pydruid.egg-info/top_level.txt
reading manifest file 'pydruid.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.txt' under directory 'docs'
writing manifest file 'pydruid.egg-info/SOURCES.txt'
running check
copying files to pydruid-0.999.0.dev0...
copying .tox/py37/lib/python3.7/site-packages/numpy/ma/tests/test_old_ma.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/ma/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/ma/tests/test_regression.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/ma/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/ma/tests/test_subclassing.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/ma/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/__init__.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/defmatrix.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/setup.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/__init__.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_defmatrix.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_interaction.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_masked_matrix.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_matrix_linalg.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_multiarray.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_numeric.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests/test_regression.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/matrixlib/tests
copying .tox/py37/lib/python3.7/site-packages/numpy/polynomial/__init__.py -> pydruid-0.999.0.dev0/.tox/py37/lib/python3.7/site-packages/numpy/polynomial
villebro commented 4 years ago

This is really infuriating. Let me research this some more so we can get this properly fixed.

mistercrunch commented 4 years ago

I fixed the issue, 0.6.1 is out.

My "solution" was to nuke my repo and re-clone clean. I have no idea what in the filesystem caused setuptools to do this.