search

druid-io / pydruid

A Python connector for Druid
Other
506 stars 194 forks source link

Use named parameters with Cursor and Connection objects #261

Open austenLacy opened 3 years ago

austenLacy commented 3 years ago

Closes: https://github.com/druid-io/pydruid/issues/232

Rather than rely on correct parameter ordering, this change switches to using named parameters to avoid out of order parameters.

This bug resulted in having to do this hack to get client certificate authentication working with Druid and Superset

hack (bad)

"engine_params": {
    "connect_args": {
      "proxies": "/path/to/my.cert"
    }
}

what it should be (good)

"engine_params": {
    "connect_args": {
      "ssl_client_cert": "/path/to/my.cert"
    }
}