search

druid-io / pydruid

A Python connector for Druid
Other
505 stars 194 forks source link

Correct order of parameters for Cursor's init #301

Closed shek1608 closed 2 months ago

shek1608 commented 1 year ago

Fix for issue https://github.com/druid-io/pydruid/issues/300

Order of parameters passed has ssl_client_cert followed by proxies https://github.com/druid-io/pydruid/blob/master/pydruid/db/api.py#L176-L177

gianm commented 7 months ago

In case someone outside pydruid code is using the Cursor constructor, how about changing the call site at https://github.com/druid-io/pydruid/blob/master/pydruid/db/api.py#L169-L177 instead of the __init__ method? Seems safer.