support javascript filter

druid-io / pydruid

A Python connector for Druid

Other

507 stars 198 forks source link

support javascript filter #38

Closed nmckoy closed 8 years ago

nmckoy commented 8 years ago

Hey!

Started using pydruid for some export functionality i needed for some queries. needed to get a little more specific with JS filters and noticed there wasn't support for it. I plopped some code in and it works great locally so i decided to PR my change for review.

This would be syntax for python query:

filter=JavaScript('dim1') == 'function(x){return true}'

Let me know if this syntax could improve.

Thanks!

fjy commented 8 years ago

@nmckoy I'm +1 on the syntax

@xvrl @gianm thoughts?

fjy commented 8 years ago

@nmckoy do you mind signing the CLA here? druid.io/community/cla.html

nmckoy commented 8 years ago

@fjy just signed!

fjy commented 8 years ago

:+1:

@xvrl can we get this in???

xvrl commented 8 years ago

:+1: