druid-io / pydruid

A Python connector for Druid
Other
507 stars 198 forks source link

Adding support for regex filter #52

Closed mistercrunch closed 8 years ago

mistercrunch commented 8 years ago

I need support for this type of filter in order to add the feature in Caravel

mistercrunch commented 8 years ago

Oh that was quick. What's your release schedule to Pypi like? Just trying to figure out whether I should run off of my fork or wait a little.

xvrl commented 8 years ago

I can release on Monday if you want.

On Friday, May 20, 2016, Maxime Beauchemin notifications@github.com wrote:

Oh that was quick. What's your release schedule to Pypi like? Just trying to figure out whether I should run off of my fork or wait a little.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/druid-io/pydruid/pull/52#issuecomment-220739810

dakra commented 8 years ago

I would appreciate a release to pypi as well.

One thing to note is that pull request #39 removed the from pydruid.foo import * entries in pydruid.client ( https://github.com/druid-io/pydruid/pull/39/files#diff-2d63becb1827470fd6f4928a4cde5b2eL30 ).

from foo import * is not a good practice in python so removing those is good but it introduces incompatibilities with the old version.

So we can either, a) change the documentation (README still uses from pydruid.client import * and note it in the changelog. b) import all things explicit to make it backwards-compatible again. (this is more work but considered better practice than import *, see for example sqlalchemy: https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/__init__.py )

mistercrunch commented 8 years ago

Yeah I hit one of those as well and adapted my code. I had to change some references from client.query_dict to client.query_builder.last_query.query_dict.

You may want to crank the version to 0.3.0 (pre 1.0 release are expected to have breaking changes on the second digit) and add info in the release notes.

xvrl commented 8 years ago

@mistercrunch @dakra released https://pypi.python.org/pypi/pydruid/0.3.0