search

druid-io / pydruid

A Python connector for Druid
Other
507 stars 198 forks source link

thetaSketch support #72

Closed ratb3rt closed 7 years ago

ratb3rt commented 7 years ago

Add support for thetaSketch aggregators and postAggregators.

ratb3rt commented 7 years ago

Rebased to latest master, to allow merge

ratb3rt commented 7 years ago

Rebased again. Are there any blocks to a merge @nishantmonu51 ?

joshwalters commented 7 years ago

@RichRadics Will this also support Theta Sketches in arithmetic post-aggs (*, /, etc)? If so, awesome!

ratb3rt commented 7 years ago

@joshwalters it should work fine - the implementation returns a postAggregator object so should be combinable with the other types perfectly well.

joshwalters commented 7 years ago

Just reviewed the code in Superset, this patch should fix the post-agg theta sketch issue we have been seeing. @nishantmonu51 is there anything we can do to help get this merged in?

gianm commented 7 years ago

Thanks @RichRadics!

Could you please fill out our CLA here so we can commit your patch: http://druid.io/community/cla.html

gianm commented 7 years ago

thanks!