Possible Server race condition/inconsistency

[drunderscore]

This one is bizarre. With the following patch:

diff --git a/Server/Client.cpp b/Server/Client.cpp
index c506834..859cf61 100644
--- a/Server/Client.cpp
+++ b/Server/Client.cpp
@@ -187,6 +187,8 @@ void Client::on_ready_to_read()

     // TODO: Some of these packets contain the player id, but we ignore that and assume it's the player id we assigned to this socket.

+    outln("received a {}", packet_id);
+
     // Connection request, let's send a user slot
     if (packet_id == Terraria::Net::Packet::Id::ConnectRequest)
     {

The client will crash before loading into the world. I suppose we're barely sending things in the right order, and the delay puts things too far apart or out of order? But it's TCP so order shouldn't matter but maybe the game ticks within that time before it gets a value it expects to have at some point.

[drunderscore]

Does not seem to occur anymore